Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BP] static tests forbid or instead of 21062 #21543

Merged
merged 1 commit into from Mar 24, 2019
Merged

[BP] static tests forbid or instead of 21062 #21543

merged 1 commit into from Mar 24, 2019

Conversation

novikor
Copy link
Contributor

@novikor novikor commented Mar 1, 2019

Description (*)

Added Squiz.Operators.ValidLogicalOperators PHP-CS rule

Fixed Issues (if relevant)

  1. Static tests: forbid 'or' instead of '||' #21062: Static tests: forbid 'or' instead of '||'

Manual testing scenarios (*)

Just make sure PHP-CS asks you to avoid the literal logical operators

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@novikor novikor requested a review from orlangur March 1, 2019 14:57
@magento-engcom-team
Copy link
Contributor

Hi @novikor. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Release Line: 2.2 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Mar 1, 2019
@orlangur orlangur self-assigned this Mar 1, 2019
@novikor novikor closed this Mar 1, 2019
@novikor novikor force-pushed the 22-Static-tests-forbid-or-instead-of-21062 branch from 3b74098 to 6ddfc58 Compare March 1, 2019 15:04
@ghost
Copy link

ghost commented Mar 1, 2019

Hi @novikor, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Static tests: forbid 'or' instead of '||' magento#21062.
9f0ef59 
Added Squiz.Operators.ValidLogicalOperators rule
@novikor novikor reopened this Mar 1, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4415 has been created to process this Pull Request

@nmalevanec nmalevanec self-assigned this Mar 22, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Mar 24, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 9f0ef59 into magento:2.2-develop Mar 24, 2019
@ghost
Copy link

ghost commented Mar 24, 2019

Hi @novikor, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 24, 2019
@sidolov
ENGCOM-4415: [BP] static tests forbid or instead of 21062 #21543
25e2fac
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

@nmalevanec nmalevanec

Labels
Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@novikor @magento-engcom-team @orlangur @nmalevanec